-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ability to add task subschema #6566
Conversation
31efcf1
to
8c0e00c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elaihau please finish the review
Signed-off-by: Roman Nikitenko <[email protected]>
8c0e00c
to
af287fa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested with Roman's extension, and confirm both "add schema" and "remove schema" work.
@akosyakov |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
code-wise looks good, thank you!
What it does
At the moment default schema and schemes of customized
detected
tasks are registered, so only these tasks are available for running.The PR provides ability to add task subschema from an extension for a custom task type to get ability run it from
Terminal => Run Task
menu.How to test
Please use my forked repo for testing, it contains:
git clone https://github.com/RomanNikitenko/theia.git
cd theia/
andgit checkout task-extension
.tasks.json
file, so please open the cloned project:File=>Open...
and select the project.Terminal => Run Task
menu:you can see that only
SHELL task
is available for runningHelp
menu and selectAdd CHE task schema
you can see that now
CHE task
is available for running as well asSHELL task
.EXEC task
CHE task
andEXEC task
usingHelp
menuyou can see that the corresponding tasks are not available for running after that.
Please see https://youtu.be/VOuFi9M2Q2k
Review checklist
Reminder for reviewers
Signed-off-by: Roman Nikitenko [email protected]