Make yarn rebuild:electron fail explicitly on Windows

[paul-marechal]

What it does

Before this commit, the yarn rebuild:electron used to fail silently.
We now get a proper output and exit code.

How to test

On Windows, try to run yarn rebuild:electron. Apparently there is a failure due to some http 403 error when downloading node-gyp build dependencies.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[paul-marechal]

Current error I am having:

D:\sources\theia>yarn rebuild:electron
yarn run v1.16.0
$ theia rebuild:electron
Processing @theia/node-pty
Processing nsfw
Processing native-keymap
Processing find-git-repositories
× Rebuild Failed
Uncaught Exception:  Error: gyp info it worked if it ends with ok
gyp info using [email protected]
gyp info using [email protected] | win32 | x64
gyp info find Python using Python version 2.7.16 found at "D:\windows\programs\Python27\python.exe"
gyp http GET https://electronjs.org/headers/v4.2.12/node-v4.2.12-headers.tar.gz
gyp http 200 https://electronjs.org/headers/v4.2.12/node-v4.2.12-headers.tar.gz
gyp http GET https://electronjs.org/headers/v4.2.12/SHASUMS256.txt
gyp http GET https://electronjs.org/headers/v4.2.12/win-x86/node.lib
gyp http GET https://electronjs.org/headers/v4.2.12/win-x64/node.lib
gyp http GET https://electronjs.org/headers/v4.2.12/win-arm64/node.lib
gyp http 200 https://electronjs.org/headers/v4.2.12/SHASUMS256.txt
gyp http 403 https://electronjs.org/headers/v4.2.12/win-arm64/node.lib
gyp WARN install got an error, rolling back install
gyp ERR! configure error
gyp ERR! stack Error: 403 status code downloading arm64 node.lib
gyp ERR! stack     at Request.<anonymous> (D:\sources\theia\node_modules\electron-rebuild\node_modules\node-gyp\lib\install.js:335:22)
gyp ERR! stack     at Request.emit (events.js:194:15)
gyp ERR! stack     at Request.onRequestResponse (D:\sources\theia\node_modules\request\request.js:1066:10)
gyp ERR! stack     at ClientRequest.emit (events.js:189:13)
gyp ERR! stack     at HTTPParser.parserOnIncomingClient [as onIncoming] (_http_client.js:556:21)
gyp ERR! stack     at HTTPParser.parserOnHeadersComplete (_http_common.js:109:17)
gyp ERR! stack     at TLSSocket.socketOnData (_http_client.js:442:20)
gyp ERR! stack     at TLSSocket.emit (events.js:189:13)
gyp ERR! stack     at addChunk (_stream_readable.js:284:12)
gyp ERR! stack     at readableAddChunk (_stream_readable.js:265:11)
gyp ERR! System Windows_NT 10.0.17763
gyp ERR! command "D:\\windows\\programs\\nodejs\\node.exe" "D:\\sources\\theia\\node_modules\\electron-rebuild\\node_modules\\node-gyp\\bin\\node-gyp.js" "rebuild" "--target=4.2.12" "--arch=x64" "--dist-url=https://electronjs.org/headers" "--build-from-source"
gyp ERR! cwd D:\sources\theia\node_modules\@theia\node-pty
gyp ERR! node -v v10.15.3
gyp ERR! node-gyp -v v5.0.5
gyp ERR! not ok

Failed with exit code: 1

[paul-marechal]

Even if a new error is brought to light by this PR, I think we should merge it sooner than later. Not seeing errors doesn't mean there aren't errors. Especially when the Electron build doesn't work because of this silent error.

[lmcbout]

seems good

[paul-marechal]

@kittaakos change is minimal, is it good for you too? :)

[kittaakos]

Is this PR somehow related to #6529?

[kittaakos]

@kittaakos change is minimal, is it good for you too? :)

I can see the error on yarn electron:rebuild.

I think we should merge it sooner than later.

Why do not we fix the error and merge with this additional check?

[paul-marechal]

If you know how to fix the 403 error then please do. I don't know how, besides waiting for electron rebuild next release.

[kittaakos]

If you know how to fix the 403 error then please do. I don't know how, besides waiting for electron rebuild next release.

No, I do not know either.

[paul-marechal]

Will merge then :)

[kittaakos]

Will merge then :)

👍 Please go ahead. Do not know why is it so urgent to merge without the fix. What will be the difference?

[paul-marechal]

The difference will be that people will see the actual error causing Windows Electron apps to fail, and not see a consequent failure and not understand.

I think this node-gyp issue could be fixed via resolutions in dependents, just like what happened with the different vscode packages? Maybe.