support "group" in the task config

[elaihau]

• With this change users would be able to define and run build tasks,
  test tasks, default build tasks, and default test tasks.
• resolves [tasks] support 'group' in tasks #6144

Signed-off-by: Liang Huang [email protected]

How to test

Use case 1:

• prepare a workspace where configured and detected tasks are defined
• add "group": "build" to task configs in tasks.json
• start "run build task" from the top menu bar "Terminal -> Run build task..."
• check if all task configs that are marked as "build tasks" are available from the list populated by the previous step, and if they can be run.

Use case 2:

• prepare a workspace where configured and detected tasks are defined
• ensure there are no task configs marked as "build tasks"
• start "run build task" from the top menu bar "Terminal -> Run build task..."
• Check if an action populated - once clicked there should be a list of tasks presented for the user to select which task would be configured as the "default build task"
• Once the "default build task" is chosen, and "run build task" is started, the default build task should be run automatically.

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

• Approval of CQ https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20967

[vince-fugnitto]

In general everything works great :)

A few things I noticed:

1. when configuring the default build task through the menu item, I think we should open the tasks.json as well like VS Code
2. when configuring the default test task through the menu item, I think we should open the tasks.json as well like VS Code
3. if a workspace has no tasks present, should we add better user feedback when they try and execute run build task and run test task? (perhaps similarly as run task display no tasks found)

[elaihau]

Thank you for the review @vince-fugnitto !
I resolved your comments. See you in office later (if you are in office)!

[vince-fugnitto]

Thank you for the review @vince-fugnitto !
I resolved your comments. See you in office later (if you are in office)!

See you soon! 😃

[vince-fugnitto]

I added a follow-up issue which I think we can improve in the future: #6525
I noticed one discrepancy between our implementation and VS Code.
Do we want to cover it during this PR or as an enhancement later?

Scenario

• Configure two different tasks as the default build tasks
  • Theia: executes the first default build task
  • VS Code: prompts users to select the build task

[elaihau]

I resolved the issue where multiple default build/test tasks are defined in the config.

[vince-fugnitto]

It works correctly for me 😄
Thank you for making the adjustments!