Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update decorations when clearing search fix #6498 #6511

Merged
merged 1 commit into from
Nov 8, 2019

Conversation

ericschmidt14
Copy link
Contributor

What it does

This fixes the issue #6498 describing that the decorations in Theia still highlight the last search result when clicking 'Clear Search Results' or clearing the search input manually.

How to test

  • Open a workspace
  • Press Ctrl + Shift + F
  • Search for anything
  • Click on a file in the result tree
  • Press 'Clear Search Results' or clear search input completely

Review checklist

Reminder for reviewers

@vince-fugnitto
Copy link
Member

@ericschmidt14 thank you for your first contribution! 👍
Please be sure to sign-off your commit accept the Eclipse ECA.
They are the reason for the failed CI check.

@vince-fugnitto
Copy link
Member

It works nicely 😃

@ericschmidt14 ericschmidt14 force-pushed the fix-clear-search branch 2 times, most recently from e3012cb to c134db9 Compare November 7, 2019 18:36
@ericschmidt14
Copy link
Contributor Author

@vince-fugnitto Thank you! 👌
I amended the last commit, signed it and force-pushed it back, but unfortunately it doesn't seem to work..

@vince-fugnitto
Copy link
Member

@vince-fugnitto Thank you!
I amended the last commit, signed it and force-pushed it back, but unfortunately it doesn't seem to work..

I verified and it says that it is not yet registered :(

image

Are you sign-off and Eclipse ECA using the same email?

@ericschmidt14
Copy link
Contributor Author

Here we go, this time it worked :)

@vince-fugnitto vince-fugnitto added the search in workspace issues related to the search-in-workspace label Nov 7, 2019
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It works great! 👍
Thank you very much for the fix, I hope to see more contributions from you in the future!
I will wait until tomorrow to merge the PR so others can get a chance to try it themselves if they'd like.

@akosyakov
Copy link
Member

@vince-fugnitto please help with merging

@vince-fugnitto vince-fugnitto merged commit 2f3b2c3 into eclipse-theia:master Nov 8, 2019
@fgreinacher fgreinacher deleted the fix-clear-search branch November 8, 2019 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
search in workspace issues related to the search-in-workspace
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants