Support integrated terminal

[tolusha]

Signed-off-by: Anatoliy Bazko [email protected]

Reference issue

#6103

What it does

It creates terminal in a proper way.

How to test

1. Add VS Code Python extension https://github.com/Microsoft/vscode-python/releases/download/2019.5.18875/ms-python-release.vsix
2. Open any python file
3. Add debug configuration

{
            "name": "Python: Current File",
            "type": "python",
            "request": "launch",
            "program": "${file}",
            "console": "integratedTerminal"
        }

4. Add some breakponits
5. Start debugging
6. Check that console is opened and all debug features work well

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

[akosyakov]

changes make sense and code-wise looks good to me

Could someone please test whether it works?

[vince-fugnitto]

changes make sense and code-wise looks good to me

Could someone please test whether it works?

I'll test it now :)

[vince-fugnitto]

It works correctly for me :)

[akosyakov]

@tolusha please clean up the history and merge 🚀

[paul-marechal]

@akosyakov This part is causing us issues, but it is also a bad thing to do to send un-escaped commands to a shell like this. IIUC, the idea is that we want to reuse a shell widget to display the output. But in this case it seems like we try to reuse actual shell processes, instead of reusing widgets.

Since this is broken for us, I will start trying to look at what is required to reuse shell widgets, do you have any opinions and/or pointers for me?

cc @marcdumais-work

[paul-marechal]

Maybe better to open an issue, will do that.

[akosyakov]

here is VS Code implementation:https://github.com/microsoft/vscode/blob/43e3581aa635406ada2d8138d7ee242ddabefc1c/src/vs/workbench/contrib/debug/node/terminals.ts#L79

We can reuse it.

[paul-marechal]

I don't like this, but it may indeed be the easiest solution here. Why would we convert a nice array of arguments into one big escaped string though? We can spawn processes directly from a command + arguments. Do debug adapters expect that their clients will provide variable-expansion or other shell-specific behaviors?

[paul-marechal]

After looking more into it, we do want to use shells. Things like running node without specifying a full path wouldn't work otherwise. Not sure we want to try to always reuse the same shell process though. In VS Code they check before reusing a shell that it doesn't have child processes running, this seems sketchy. I would rather make sure the shell dies when the command is executed, and reuse the widget if process is dead. WDYT?

[akosyakov]

Don't get it. Here is a solution, which we can copy and fix the issue, and then focus on something else instead of spending time reinventing our solution. Plus it makes it easier to catch up later if there are some bug fixes.

Not sure we want to try to always reuse the same shell process though. In VS Code they check before reusing a shell that it doesn't have child processes running, this seems sketchy. I would rather make sure the shell dies when the command is executed, and reuse the widget if process is dead. WDYT?

Sorry, I don't know how it is related to escaping. We start a new terminal each time for now. Please file a new issue if there is a mismatch from user perspective with steps how to reproduce in Theia and VS Code.

[paul-marechal]

Terminals are reused when handling runInTerminal requests:

[paul-marechal]

But apparently VS Code has the same issue when running the same command, user can pollute the shell that the extension tries to send commands to... Ok.