Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] add explicit 'yargs' dependency #6443

Merged
merged 1 commit into from
Oct 24, 2019
Merged

[cli] add explicit 'yargs' dependency #6443

merged 1 commit into from
Oct 24, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

Added explicit yargs dependency to @theia/cli under dev-packages. Fixes an issue where users/extenders cannot successfully use the @theia/cli package when working outside of the main repository monorepo.

Originally from @cortopy #6418.

How to test

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]
Co-authored-by: Juan Jimenez-Anca [email protected]

Added explicit `yargs` dependency to `@theia/cli` under
`dev-packages`. Fixes an issue where users/extenders
cannot successfully use the `@theia/cli` package
when working outside of the main repository monorepo.

Originally from @cortopy #6418.

Signed-off-by: vince-fugnitto <[email protected]>
Co-authored-by: Juan Jimenez-Anca <[email protected]>
@vince-fugnitto vince-fugnitto added the dependencies pull requests that update a dependency file label Oct 23, 2019
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me; thank you! 👍

@vince-fugnitto
Copy link
Member Author

Thank you @cortopy for the changes!

@vince-fugnitto vince-fugnitto merged commit 853d6b3 into master Oct 24, 2019
@vince-fugnitto vince-fugnitto deleted the vf/yargs branch October 24, 2019 10:11
@cortopy
Copy link
Contributor

cortopy commented Oct 24, 2019

@vince-fugnitto my pleasure!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants