[safari] fix incorrect command palette cursor position

[vince-fugnitto]

What it does

Fixes #6011

Fixes incorrect command palette cursor position especially on Safari browser.
Added additional handling to verify that if no selection is currently present,
force the cursor at the end of the input. Inspired by a similar implementation
in VS Code.

How to test

1. open the command palette ctrlcmd+shift+p
2. ensure that the cursor is placed at the end of the prefix
3. verify in multiple browsers (ex: Safari, Chrome, Firefox)

Review checklist

• as an author, I have thoroughly tested my changes and carefully followed the review guidelines
• CQ registered
• CQ approved

Reminder for reviewers

• as a reviewer, I agree to behave in accordance with the review guidelines

Signed-off-by: Vincent Fugnitto [email protected]

[lmcbout]

Code wise: OK

Tested on Ubuntu 16.04
Chrome: before and after the fix, no change: working
Firefox: "ctrl+ shift + p" open a private browser, not the quick command. : Unable to see the cursor position when opening the quick menu from the key binding.

Safari: I don't have it, :(

Electron: before and after: same behavior: working fine

[vince-fugnitto]

Chrome: before and after the fix, no change: working

👍

Firefox: "ctrl+ shift + p" open a private browser, not the quick command. : Unable to see the cursor position when opening the quick menu from the key binding.

I am able to see the cursor on Firefox (verified with and without a private window).

Safari: I don't have it :(

You can verify at work using the Macbook.

Electron: before and after: same behavior: working fine

👍

[kittaakos]

I have checked in FF, Chrome, and Safari. FF and Chrome are the same as they were, and now it works in Safari too.

Thank you! 👍

[vince-fugnitto]

The CQ has been approved, I will proceed with merging.
Thank you @kittaakos for the review :)