Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(OutputChannelRegistry): introduce interface and add it into rpc #6413

Merged
merged 1 commit into from
Oct 18, 2019

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Oct 17, 2019

What it does

It allows to grab later the object from RPC

How to test

value is added to RPC as most of the other objects.

Review checklist

Reminder for reviewers

Change-Id: I84af8bbc9fdcd768e11cff6d1bc270cd669b34ef
Signed-off-by: Florent Benoit <[email protected]>
@akosyakov akosyakov requested review from JPinkney and olexii4 October 17, 2019 15:44
@akosyakov akosyakov added the plug-in system issues related to the plug-in system label Oct 17, 2019
Copy link
Contributor

@mmorhun mmorhun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit f255f5a into master Oct 18, 2019
@benoitf benoitf deleted the output-channel-registry branch October 18, 2019 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants