Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the 'keymaps' documentation. #6369

Merged
merged 1 commit into from
Oct 15, 2019
Merged

Update the 'keymaps' documentation. #6369

merged 1 commit into from
Oct 15, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

Update the documentation of the @theia/keymaps extension as part of the ongoing effort to improve documentation for the milestone 1.0.0 release.

Note: (the following tslint checks were added to the errors.tslint.json during testing)

"rules": {
    "completed-docs": [true, "enums", "enum-members", "functions", "interfaces", "methods"],
    "no-redundant-jsdoc": true,
}

How to test

Verify the documentation.

Review checklist

Reminder for reviewers

Signed-off-by: Vincent Fugnitto [email protected]

@vince-fugnitto vince-fugnitto added keybindings issues related to keybindings documentation issues related to documentation labels Oct 11, 2019
@vince-fugnitto vince-fugnitto self-assigned this Oct 11, 2019
- update the documentation of the `@theia/keymaps` extension as
part of the ongoing effort to improve documentation for the
milestone 1.0.0 release.

Signed-off-by: Vincent Fugnitto <[email protected]>
Copy link
Contributor

@elaihau elaihau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good. Thank you Vincent !

@vince-fugnitto vince-fugnitto merged commit 2a48eb8 into master Oct 15, 2019
@vince-fugnitto vince-fugnitto deleted the vf/keymaps-docs branch October 15, 2019 10:22
@vince-fugnitto
Copy link
Member Author

Thank you for the review @elaihau !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation issues related to documentation keybindings issues related to keybindings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants