Fix cancellable option for withProgress
#6365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
added
progress
akosyakov
reviewed
Oct 11, 2019
akosyakov
approved these changes
Oct 11, 2019
also cleaned up unused `NotificationMain.$startProgress` options. Fixes #5578 Signed-off-by: Alex Tugarev <[email protected]>
|
thx @AlexTugarev. looks simpler to me, works nicely as well |
|
thanks for reviewing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
This PR makes the
cancellableoption being considered forwithProgressnotifications.Fixes #5578
How to test
TXT: Progresscommandnow the
cancellable: falseoption should have the same effect as in vscodeReview checklist
Reminder for reviewers