add content assist for input variables in tasks.json #6334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- content assist is added to help the users of tasks.json input variables. - changes made to VariableResolverService and CommonVariableContribution in #6331 are reverted. Signed-off-by: Liang Huang <[email protected]>
|
I am also checking what I can do in |
|
@elaihau I don’t think we need to change clients to handle undefined, but do #6333 (comment) |
akosyakov
reviewed
Oct 7, 2019
There was a problem hiding this comment.
Code changes look good to me. I can test only later. @vince-fugnitto could you give It a go please?
akosyakov
approved these changes
Oct 7, 2019
vince-fugnitto
approved these changes
Oct 7, 2019
|
please merge |
|
@elaihau I merged for you :) |
|
Thank you Vincent! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in support input variables for tasks #6331 are reverted.
Signed-off-by: Liang Huang [email protected]
How to test
.theia/tasks.json, and enter input variables.Review checklist