[Fylesystem] Fixed error on handling of nsfw RENAMED event #6283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
federicobozzini
force-pushed
the
master
branch
from
d0df96e to
e405395
Compare
federicobozzini
changed the title
akosyakov
reviewed
Sep 27, 2019
packages/filesystem/src/node/nsfw-watcher/nsfw-filesystem-watcher.ts
Outdated
Show resolved
Hide resolved
|
@federicobozzini good catch, but i'm unsure that |
akosyakov
reviewed
Oct 1, 2019
packages/filesystem/src/node/nsfw-watcher/nsfw-filesystem-watcher.ts
Outdated
Show resolved
Hide resolved
|
@federicobozzini please squash commits and sign them then we can merge it, thank you! |
federicobozzini
force-pushed
the
master
branch
from
becc9b8 to
2ed4fd0
Compare
Signed-off-by: Federico Bozzini <[email protected]>
federicobozzini
force-pushed
the
master
branch
from
2ed4fd0 to
c264a8e
Compare
|
Done. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The typing of a nsfw RENAMED event is incomplete. When a file is moved, Theia handles the event incorrectly.
What it does
This PR fixes the typing of the nfws events and handles the file moving correctly.
How to test
Open Theia with a debugger and move a file. It's possible to see that the nfws event received has a newDirectory property that at the moment was not used.
Review checklist
Reminder for reviewers