Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev] Add electron backend and composite electron launch #6226

Merged
merged 1 commit into from
Sep 20, 2019
Merged

[dev] Add electron backend and composite electron launch #6226

merged 1 commit into from
Sep 20, 2019

Conversation

thegecko
Copy link
Member

Signed-off-by: thegecko [email protected]

What it does

  • Adds ability to attach to the electron frontend
  • Adds composite launch config for electron backend and frontend together
  • Some minor launch name changes to align nomenclature

How to test

  • Open in VSCode
  • Select one of the new launch configs
  • Start debug

Review checklist

Reminder for reviewers

@thegecko thegecko requested a review from a team September 20, 2019 07:29
marcdumais-work
marcdumais-work approved these changes Sep 20, 2019
View reviewed changes
Copy link
Contributor

@marcdumais-work marcdumais-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one minor comment added. I tested the combined Electron launch and was able to debug both BE and FE

.vscode/launch.json Outdated
],
"compounds": [
{
"name": "Electron Backend & Frontend",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add "Launch" in front so it follows the same pattern as other entries?

Copy link
Member Author

@thegecko thegecko Sep 20, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will do

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have updated as suggested

@thegecko thegecko force-pushed the launch-electron-frontend branch from d57428d to b7d7f48 Compare September 20, 2019 15:45
@thegecko thegecko merged commit 8d232fa into eclipse-theia:master Sep 20, 2019
@thegecko thegecko deleted the launch-electron-frontend branch September 20, 2019 15:46
@akosyakov
Copy link
Member

@thegecko @marcdumais-work please update dev docs as well: https://github.com/eclipse-theia/theia/blob/master/doc/Developing.md#debug-the-browser-examples-backend

@thegecko thegecko mentioned this pull request Sep 21, 2019
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcdumais-work marcdumais-work marcdumais-work approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@thegecko @akosyakov @marcdumais-work