Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[git] handle attempting to sign-off without configs #6222

Merged
merged 1 commit into from
Sep 23, 2019

Conversation

vince-fugnitto
Copy link
Member

What it does

Fixes #4908

Handle the toolbar action to add a sign-off when the
user does not have their user.name and user.email configured.

Screen Shot 2019-09-19 at 3 30 43 PM

How to test

  1. ensure that the git config is not set (ex: open ~/.gitconfig and comment out user.name and user.email entries
  2. attempt to create a commit in the application, and click the sign-off toolbar button
  3. a warning should be displayed that no config is set
  4. un-comment out the entries in the gitconfig
  5. retry step 2, the sign-off should be added in the commit message

Review checklist

Reminder for reviewers

Signed-off-by: vince-fugnitto [email protected]

Fixes #4908

Handle the toolbar action to add a sign-off when the
user does not have their `user.name` and `user.email` configured.

Signed-off-by: vince-fugnitto <[email protected]>
@vince-fugnitto vince-fugnitto added bug bugs found in the application git issues related to git labels Sep 19, 2019
@vince-fugnitto vince-fugnitto self-assigned this Sep 19, 2019
@vince-fugnitto
Copy link
Member Author

I was debating over whether to use a warning directly bellow the input or through the message-service. I ultimately decided on bellow the input since the sign-off directly affects the commit message. If others have any other opinions please let me know.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it in GItpod with the following commands:

git config --global --unset user.name
git config --global set user.name "Foo Bar"

It worked as described. 👍

@vince-fugnitto vince-fugnitto merged commit f949db1 into master Sep 23, 2019
@vince-fugnitto vince-fugnitto deleted the vf/GH-4908 branch September 23, 2019 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bugs found in the application git issues related to git
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git Add Signed-off-by error if not set email and username
2 participants