-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated inversify to 5.0.1 #6184
Conversation
Signed-off-by: Miro Spönemann <[email protected]>
I do not know if it is related, but I can see this in the console:
I have tried it on macOS with the electron example. 845829e |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, cannot reproduce @kittaakos issue on Ubuntu.
@kittaakos that exception seems to be a long-standing Electron problem: electron/electron#8205 |
I have not seen this before. Let me compare your changes with the |
I do not see the same error on the |
I could not reproduce this on |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have verified it on macOS with the electron example. I have tried to open multiple workspaces, checked the JS/TS LS: it worked.
What it does
Fixes #3298.
CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20823
How to test
Everything should work as before.
Review checklist
Reminder for reviewers