Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated inversify to 5.0.1 #6184

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Updated inversify to 5.0.1 #6184

merged 1 commit into from
Sep 16, 2019

Conversation

spoenemann
Copy link
Contributor

@spoenemann spoenemann commented Sep 13, 2019

What it does

Fixes #3298.

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20823

How to test

Everything should work as before.

Review checklist

Reminder for reviewers

Signed-off-by: Miro Spönemann <[email protected]>
@kittaakos
Copy link
Contributor

I do not know if it is related, but I can see this in the console:

Error: Cannot call function 'setApplicationMenu' on missing remote object 11
    at throwRPCError (/Users/akos.kitta/git/theia/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:145:17)
    at EventEmitter.<anonymous> (/Users/akos.kitta/git/theia/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/rpc-server.js:367:7)
    at EventEmitter.emit (events.js:182:13)
    at WebContents.<anonymous> (/Users/akos.kitta/git/theia/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/browser/api/web-contents.js:294:13)
    at WebContents.emit (events.js:182:13)
    at metaToException (/Users/akos.kitta/git/theia/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:271:17)
    at Object.exception (/Users/akos.kitta/git/theia/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:219:30)
    at metaToValue (/Users/akos.kitta/git/theia/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:223:28)
    at Function.remoteMemberFunction (/Users/akos.kitta/git/theia/node_modules/electron/dist/Electron.app/Contents/Resources/electron.asar/renderer/api/remote.js:123:16)
    at file:///Users/akos.kitta/git/theia/examples/electron/lib/55.bundle.js:215:38
    at file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:109319:33
    at CallbackList.../../packages/core/lib/common/event.js.CallbackList.invoke (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:109334:39)
    at Emitter.../../packages/core/lib/common/event.js.Emitter.fire (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:109422:29)
    at KeybindingRegistry.../../packages/core/lib/browser/keybinding.js.KeybindingRegistry.setKeymap (file:///Users/akos.kitta/git/theia/examples/electron/lib/bundle.js:87590:33)
    at KeymapsService.<anonymous> (file:///Users/akos.kitta/git/theia/examples/electron/lib/48.bundle.js:1416:49)

I have tried it on macOS with the electron example. 845829e

Copy link
Member

@paul-marechal paul-marechal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, cannot reproduce @kittaakos issue on Ubuntu.

@akosyakov akosyakov added the dependencies pull requests that update a dependency file label Sep 16, 2019
@spoenemann
Copy link
Contributor Author

@kittaakos that exception seems to be a long-standing Electron problem: electron/electron#8205
I believe it's not related to Inversify.

@kittaakos
Copy link
Contributor

seems to be a long-standing Electron problem

I have not seen this before. Let me compare your changes with the master state.

@kittaakos
Copy link
Contributor

Let me compare your changes with the master state.

I do not see the same error on the master.

@kittaakos
Copy link
Contributor

I do not see the same error on the master.

I could not reproduce this on GH-3298 either.

Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have verified it on macOS with the electron example. I have tried to open multiple workspaces, checked the JS/TS LS: it worked.

@spoenemann spoenemann merged commit 1808d78 into master Sep 16, 2019
@spoenemann spoenemann deleted the GH-3298 branch September 16, 2019 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[quality] Update to inversify 5.0.1
4 participants