Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

register language features even if a language is not registered #6145

Merged
merged 1 commit into from
Sep 10, 2019
Merged

register language features even if a language is not registered #6145

merged 1 commit into from
Sep 10, 2019

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Sep 9, 2019 •
edited
Loading

What it does

fix #6143: There is no a guarantee that a language is registered by the time when a language feature is registered. Before with the bad timing a language can be registered too late leading to missing language features. Now language features will be registered regardless whether a language is registered.

TODO:

  • release monaco-languageclient 0.9.1 and cherry pick the fix for 0.10.2
  • tested with typescript VS Code extension

How to test

  • uninstall textmate grammars
  • install built-in vscode extension contributing languages, i.e. for typescript
  • use native and VS Code extensions contributing language smartness for installed built-in extensions
  • start Theia
  • test that language smartness is there

Review checklist

Reminder for reviewers

@akosyakov akosyakov added monaco issues related to monaco lsp language server protocol textmate issues related to the textmate grammars vscode issues related to VSCode compatibility labels Sep 9, 2019
@akosyakov akosyakov requested a review from a team as a code owner September 9, 2019 12:54
@AlexTugarev
Copy link
Contributor

going to test with python.

@akosyakov akosyakov mentioned this pull request Sep 9, 2019
Closed
@akosyakov akosyakov requested a review from kpge September 9, 2019 12:57
svenefftinge
svenefftinge reviewed Sep 9, 2019
View reviewed changes
Copy link
Contributor

@svenefftinge svenefftinge left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to work.

I tried with vscode-native-javascript, vscode-native-typescript, vscode-native-typescript-language-features

@akosyakov
fix #6143: register language features even if a language is not regis…
f0de6d1 
…tered

There is no a guarantee that a language is registered by the time when a language feature is registered. Before with the bad timing a language can be registered too late leading to missing language features. Now language features will be registered regardless whether a language is registered.

Signed-off-by: Anton Kosyakov <[email protected]>
@akosyakov akosyakov force-pushed the ak/fix_lang_registration branch from 9f7e0ea to f0de6d1 Compare September 10, 2019 04:16
@akosyakov akosyakov merged commit a9a39db into master Sep 10, 2019
@akosyakov akosyakov deleted the ak/fix_lang_registration branch September 10, 2019 04:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

@AlexTugarev AlexTugarev Awaiting requested review from AlexTugarev

@kpge kpge Awaiting requested review from kpge

Assignees
No one assigned
Labels
lsp language server protocol monaco issues related to monaco textmate issues related to the textmate grammars vscode issues related to VSCode compatibility
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typescript LS does not install language features with built-in vscode extension
3 participants
@akosyakov @AlexTugarev @svenefftinge