Fix hosted plugin restart debug instance starts a regular instance #6131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Doron Nahari <[email protected]>
akosyakov
added
debug
|
@theia-ide/plugin-system @tolusha Could someone review please? i am not very familiar with |
tolusha
reviewed
Sep 9, 2019
|
@tolusha please approve if everything works for you and help with merging! |
|
@tolusha merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Doron Nahari [email protected]
What it does
When restarting hosted plugin debug instance, it starts a regular instance instead of debug again.
This pr fix this behaviour by updating correctly the this.isDebug parameter and restart the instance according to it's value
How to test
Start a debug instance of some theia-plugin/vscode-extension with the command Hosted Plugin: Debug Instance. after it's has been started, restart the instance with the command Hosted Plugin: Restart Instance. The new instance is not a debug instance
Review checklist
Reminder for reviewers