[textmate] don't warn when same grammar is registered multiple times #6125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Sep 6, 2019
| const existingProvider = this.scopeToProvider.get(scope); | ||
| if (existingProvider) { | ||
| Promise.all([existingProvider.getGrammarDefinition(), description.getGrammarDefinition()]).then(([a, b]) => { | ||
| if (a.location !== b.location) { |
There was a problem hiding this comment.
only if both locations are not undefined?
There was a problem hiding this comment.
Yes, I think that's enough. But if you insist ... :-)
akosyakov
reviewed
Sep 6, 2019
akosyakov
added
textmate
svenefftinge
commented
Sep 6, 2019
| console.warn(new Error(`a registered grammar provider for '${scope}' scope is overridden`)); | ||
| } | ||
| }); | ||
| return; |
There was a problem hiding this comment.
I'm removing this return again.
Fixes #6124 Signed-off-by: Sven Efftinge <[email protected]>
svenefftinge
force-pushed
the
GH-6124
branch
from
1209e65 to
9d1af3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6124
What it does
No more warnings when the same grammar is registered multiple times.
How to test
Remove textmate-grammars and install https://registry.npmjs.org/@theia/vscode-builtin-ini/-/vscode-builtin-ini-0.2.1.tgz in plugins folder
See how no warning is logged (if you do the same without this change there will be warning)
Review checklist
Reminder for reviewers