Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update vscode default api version to 1.38.0 #6112

Merged
merged 1 commit into from
Sep 5, 2019

Conversation

DoroNahari
Copy link
Contributor

@DoroNahari DoroNahari commented Sep 5, 2019

Signed-off-by: Doron Nahari [email protected]

What it does

Update vscode default api version to latest version 1.38.0
https://spectrum.chat/theia/dev/update-vscode-default-api-version~99f3833f-2f09-4b13-8784-f92f328ed87c

How to test

When running a vscode extension you can log/debug the vscode.version. (If there's a better way i would like to know)

Review checklist

Reminder for reviewers

@DoroNahari DoroNahari requested a review from a team as a code owner September 5, 2019 11:57
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@akosyakov akosyakov added the plug-in system issues related to the plug-in system label Sep 5, 2019
@akosyakov akosyakov merged commit cdfa345 into eclipse-theia:master Sep 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants