Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[vscode] vscode.extension.contributes.configuration can be array #6078

Merged
merged 1 commit into from
Sep 2, 2019

Conversation

svenefftinge
Copy link
Contributor

@svenefftinge svenefftinge commented Aug 31, 2019

What it does

Many VS Code extensions contribute the configuration object wrapped in an array.
See https://github.com/microsoft/vscode/blob/master/src/vs/workbench/api/common/configurationExtensionPoint.ts#L131-L137

Fixes #6072

How to test

  1. start the application with the following tomcat vscode extension
  2. open the preferences using the menu item File > Settings > Open Preferences
  3. there should be a new category Tomcat with the preferences:
    3.1. tomcat.workspace
    3.2. tomcat.restart_when_http(s)_port_change

Review checklist

Reminder for reviewers

@svenefftinge svenefftinge requested a review from a team as a code owner August 31, 2019 11:14
@svenefftinge svenefftinge requested a review from akosyakov August 31, 2019 11:15
@svenefftinge
Copy link
Contributor Author

@a1994846931931 could you check if this fixes #6046, too?

Copy link
Contributor

@tom-shan tom-shan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@akosyakov akosyakov added plug-in system issues related to the plug-in system preferences issues related to preferences labels Sep 1, 2019
Copy link
Member

@akosyakov akosyakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested that preference definitions as an object and array are supported.

Object:
Screen Shot 2019-09-01 at 16 46 21

Array:
Screen Shot 2019-09-01 at 16 45 18

@a1994846931931
Copy link
Contributor

@a1994846931931 could you check if this fixes #6046, too?

@svenefftinge Thank you svenefftinge! But I don't think they are related since I've confirmed that the contributes.configuration of the plugin that I tested is not an Array.

@svenefftinge svenefftinge merged commit cb213f4 into master Sep 2, 2019
@svenefftinge svenefftinge deleted the se/vscode_configuration_array branch September 2, 2019 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
plug-in system issues related to the plug-in system preferences issues related to preferences
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail to load the configuration contribution of vscode tomcat extension
4 participants