Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix menu bar color. #6014

Merged
merged 1 commit into from
Aug 23, 2019
Merged

Fix menu bar color. #6014

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/core/src/browser/style/menus.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
|----------------------------------------------------------------------------*/


.p-MenuBar {
.p-Widget.p-MenuBar {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So p-MenuBar is not used anymore?
What about this reference https://github.com/theia-ide/theia/blob/89c3e75f4a75f5850b7797ad6af3ca8ac3700149/packages/core/src/browser/style/menus.css#L60

Copy link
Contributor Author

@jbicker jbicker Aug 22, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So p-MenuBar is not used anymore?

Only in p-Widget container. Are there other containers where it maybe could be used in?

What about this reference

Since this rule is not affected by the p-Widget rule I left it out.

padding-left: 5px;
background: var(--theia-menu-color0);
color: var(--theia-ui-bar-font-color1);
Expand Down