[plugin] fix #5753: redetect languages on new grammar #5754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kittaakos
reviewed
Jul 19, 2019
packages/plugin-ext/src/main/browser/plugin-contribution-handler.ts
Outdated
Show resolved
Hide resolved
|
works as advertised! |
Signed-off-by: Anton Kosyakov <[email protected]>
|
I've updated to redetect only once. |
akosyakov
added
monaco
The second method does not have syntax highlighting. |
|
@kittaakos it is already grammar issue, the same in VS Code: |
|
@AlexTugarev @kittaakos are you fine with changes? could it be merged? |
@kittaakos that's due to the problem from L.17 as stated in the comment. |
| /* `true` because it is derived from an URI during the instantiation */ | ||
| protected _languageAutoDetected = true; | ||
|
|
||
| get languageAutoDeteceted(): boolean { |
There was a problem hiding this comment.
typo, fix: languageAutoDetected
There was a problem hiding this comment.
oh, sorry, only noticed it, could you open a follow-up PR, it won't be a breaking change
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
fix #5753: redetect languages on new grammar
How to test
Deploy Plugin by idcommand -> vscode:extension/zxh404.vscode-proto3Review checklist
Reminder for reviewers