Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added webpack-ignore for source-map-support warning (fixes #556) #558

Merged
merged 1 commit into from
Sep 26, 2017

Conversation

svenefftinge
Copy link
Contributor

No description provided.

@akosyakov
Copy link
Member

@svenefftinge
Copy link
Contributor Author

svenefftinge commented Sep 26, 2017

that's the wrong version. Using strictly 0.4.3 removed the warning. OTOH we could ignore the warning. Looking at the actual code, it seems to be expected for webpack:

 try {
      Module = require('module');
    } catch (err) {
      // NOP: Loading in catch block to convert webpack error to warning.
    }

@svenefftinge svenefftinge changed the title Added explicit dependency to source-map-support 0.4.3 (fixes #556) Added webpack-ignore for source-map-support warning (fixes #556) Sep 26, 2017
@svenefftinge svenefftinge merged commit ad1de13 into master Sep 26, 2017
@svenefftinge svenefftinge deleted the GH-556 branch September 26, 2017 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants