Sort the extension names in the 'about' dialog #5551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #3886 Add minor enhancement to the example `about` dialog present in the example applications to display the list of sorted extension names. Previously the list was unsorted which meant it was harder to identify which extensions were in fact present, and a sorted list is more adherent with good UI practices. Signed-off-by: Vincent Fugnitto <[email protected]>
vince-fugnitto
added
the
enhancement
|
Thank you @elaihau ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3886
Description
Add minor enhancement to the example
aboutdialog present in the example applicationsto display the list of sorted extension names. Previously the list was unsorted which
meant it was harder to identify which extensions were in fact present, and a sorted
list is more adherent with good UI practices.
Steps to Reproduce
aboutdialog using the menuHelp→About.Note
The example application defines it's own default
aboutdialog which is likely to be updated by different products and overwritten (comment). The enhancement is solely to sort the example-application'saboutdialog implementation.Signed-off-by: Vincent Fugnitto [email protected]