[menus] Restore the focus for context menu and main menu bar (fixes #481) #535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
) Signed-off-by: Sven Efftinge <[email protected]>
hexa00
reviewed
Sep 21, 2017
| @@ -96,6 +96,7 @@ class DynamicMenuBarWidget extends MenuBarWidget { | |||
| super['_openChildMenu'](); | |||
| }; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Do we have agreed on such formatting? I do like it better with an empty line (not that I really want to get into a discussion about it :-))
There was a problem hiding this comment.
We have not discussed it I assumed it from the rest of the code and I also prefer that...
It looked like a left over to me since no other code was touched in that function.
There was a problem hiding this comment.
It actually was a formatting change, because I like that empty line :)
There was a problem hiding this comment.
We can maybe discuss how to go about such things in today's meeting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Sven Efftinge [email protected]