-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
create problem markers from task output #5024
Conversation
@elaihau Does it cover completely problem matching compare to VS Code? How do you verify it? I cannot see any references to some sample VS Code extensions, docs and don't see new tests in the PR. |
No. "What's not included" is outlined in the description of the PR.
I tested it with running tasks detected by Gulp, Grunt, Jake, and NPM vscode extensions. And to be transparent, Jacques and I found some new missing stuffs when we sat together to test. I am currently working on problems we found.
Could you please be more specific ? I am not sure what you meant by "sample VS Code extensions, docs".
will add tests. I am on it. Thank you ! |
b53bc0e
to
19d3862
Compare
This one has been opened for a while. @akosyakov could you please take a look when you get the chance? thank you ! |
@elaihau will review it next month that it is landed in 0.8.0 |
@elaihau but you can assign your colleagues and anybody else to help with a review, they should install some vscode extensions and check that everything you fixed is aligned with VS Code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elaihau I'm fine with the changes in plugin-ext
@RomanNikitenko could you review again ?
1acfd00
to
f990231
Compare
I am testing right now, thanks! |
@benoitf |
@RomanNikitenko |
@RomanNikitenko could you please give me more details on the Theia plugin where you see the failure? It would be really nice if you could send me the url, if its source code is available somewhere online, or tell me its name if it comes from VS Code as an extension. Thank you ! Once I have more details from you, I will start some investigation to see where the problem occured. |
@RomanNikitenko please provide tests with example apps if you can, any contributor should be able to reproduce them without additional setups. If you cannot please let @elaihau know that he can continue working on compatibility with VS Code |
@elaihau |
@RomanNikitenko no worries ! I will rebase and merge this one. Please file an issue and cc me if you find any problems. Thanks ! |
What's included in this PR: - support taskDefinition, problemMatcher, & problemPattern contributed by Theia plugins. - support customizing tasks by adding named & anonymous problem matchers and patterns in .theia/tasks.json. - support parsing output from both "start - finish" tasks and "watch" tasks. - support both single line and multi line patterns. - create problem markers on parsing task output with the plugin-defined or user-defined problem matchers and patterns. What's not included: - prompt users to provide problem matcher and / or patterns before starting tasks - remove problem markers automatically when problems are fixed CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19787. Approved on June 4 2019. https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20139. Approved on June 11 2019. Signed-off-by: elaihau <[email protected]>
Signed-off-by: elaihau <[email protected]>
Removing a check that seems to be a leftover from previous change [2] [1] eclipse-theia#8930 [2] eclipse-theia#5024 (comment) Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
The issue was triggered by launching a debug session which includes a "preLaunchTask" referencing a build task. The issue happened even if the "cwd" option was present in the tasks.json file The check triggering the error was removed as the 'cwd' options should not be mandatory see 'options' under [3] as well as comment [2]. [1] eclipse-theia#8930 [2] eclipse-theia#5024 (comment) [3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
The issue was triggered by launching a debug session which includes a "preLaunchTask" referencing a build task. The issue happened even if the "cwd" option was present in the tasks.json file The check triggering the error was removed as the 'cwd' options should not be mandatory see 'options' under [3] as well as comment [2]. [1] #8930 [2] #5024 (comment) [3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
What's included in this PR:
What's not included:
CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19787. Approved on June 4 2019.
CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20139. Approved on June 11 2019.
Resolves #4211
Signed-off-by: elaihau [email protected]