create problem markers from task output #5024

elaihau · 2019-04-26T18:48:04Z

What's included in this PR:

support taskDefinition, problemMatcher, & problemPattern contributed by Theia plugins.
support customizing tasks by adding named & anonymous problem matchers and patterns in .theia/tasks.json.
support parsing output from both "start - finish" tasks and "watch" tasks.
support both single line and multi line patterns.
create problem markers on parsing task output with the plugin-defined or user-defined problem matchers and patterns.

What's not included:

prompt users to provide problem matcher and / or patterns before starting tasks
remove problem markers automatically when problems are fixed

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19787. Approved on June 4 2019.
CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20139. Approved on June 11 2019.

Resolves #4211

Signed-off-by: elaihau [email protected]

elaihau · 2019-04-26T19:06:06Z

Quick demo:

Support customising tasks by providing named problem matcher(s):

Support customise tasks by providing anonymous problem matcher(s) and pattern(s):

Support watching tasks and background (aka. watching) pattern(s):

packages/markers/src/browser/marker-manager.ts

packages/process/src/node/process.ts

packages/task/src/common/problem-matcher-protocol.ts

packages/task/src/common/task-watcher.ts

akosyakov · 2019-04-29T05:51:58Z

@elaihau Does it cover completely problem matching compare to VS Code? How do you verify it? I cannot see any references to some sample VS Code extensions, docs and don't see new tests in the PR.

packages/task/src/browser/task-configurations.ts

elaihau · 2019-05-07T14:00:33Z

Does it cover completely problem matching compare to VS Code?

No. "What's not included" is outlined in the description of the PR.

How do you verify it?

I tested it with running tasks detected by Gulp, Grunt, Jake, and NPM vscode extensions. And to be transparent, Jacques and I found some new missing stuffs when we sat together to test. I am currently working on problems we found.

I cannot see any references to some sample VS Code extensions, docs

Could you please be more specific ? I am not sure what you meant by "sample VS Code extensions, docs".

and don't see new tests in the PR.

will add tests. I am on it. Thank you !

elaihau · 2019-05-28T11:41:02Z

This one has been opened for a while. @akosyakov could you please take a look when you get the chance? thank you !

akosyakov · 2019-05-29T09:40:08Z

@elaihau will review it next month that it is landed in 0.8.0

akosyakov · 2019-05-29T09:41:24Z

@elaihau but you can assign your colleagues and anybody else to help with a review, they should install some vscode extensions and check that everything you fixed is aligned with VS Code

packages/task/src/browser/task-definition-registry.ts

elaihau · 2019-07-03T15:31:52Z

@benoitf @evidolob I made some changes to the plugin-ext in this PR, are you ok with the change ? Thank you !

benoitf

@elaihau I'm fine with the changes in plugin-ext

@RomanNikitenko could you review again ?

RomanNikitenko · 2019-07-04T07:08:50Z

@RomanNikitenko could you review again ?

I am testing right now, thanks!

RomanNikitenko · 2019-07-04T21:11:03Z

@RomanNikitenko could you review again ?

@benoitf
I tested the changes on minikube, started workspace from devfile.
Che tasks defined in devfile (I added simple commands like build and watch for theia project) work as expected except known issues.
The only thing I noticed that tasks from remote plugins are absent in 'Run tasks' menu (in my case I had typescript plugin).
But maybe something wrong with my assembly and typescript plugin has not started.

elaihau · 2019-07-04T21:48:52Z

The only thing I noticed that tasks from remote plugins are absent in 'Run tasks' menu (in my case I had typescript plugin).

@RomanNikitenko
Thank you for the testing
when you said "typescript plugin", did you refer to the typescript-language-features from vscode ? That one does not work with Theia. I haven't got the chance to go through its code to figure out what's missing in Theia.

elaihau · 2019-07-05T14:05:48Z

@RomanNikitenko could you please give me more details on the Theia plugin where you see the failure? It would be really nice if you could send me the url, if its source code is available somewhere online, or tell me its name if it comes from VS Code as an extension. Thank you !

Once I have more details from you, I will start some investigation to see where the problem occured.

akosyakov · 2019-07-05T15:26:42Z

@RomanNikitenko please provide tests with example apps if you can, any contributor should be able to reproduce them without additional setups. If you cannot please let @elaihau know that he can continue working on compatibility with VS Code

RomanNikitenko · 2019-07-08T10:47:07Z

@elaihau
I'm sorry for delay, we had three-day weekend in our office and I was offline.
I think you can merge your PR to do not delay the process, because maybe some problem is on our side.
I'll test again and create an issue if any problem will be found.
Is it OK for you?

elaihau · 2019-07-09T00:03:22Z

@RomanNikitenko no worries ! I will rebase and merge this one. Please file an issue and cc me if you find any problems. Thanks !

What's included in this PR: - support taskDefinition, problemMatcher, & problemPattern contributed by Theia plugins. - support customizing tasks by adding named & anonymous problem matchers and patterns in .theia/tasks.json. - support parsing output from both "start - finish" tasks and "watch" tasks. - support both single line and multi line patterns. - create problem markers on parsing task output with the plugin-defined or user-defined problem matchers and patterns. What's not included: - prompt users to provide problem matcher and / or patterns before starting tasks - remove problem markers automatically when problems are fixed CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19787. Approved on June 4 2019. https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20139. Approved on June 11 2019. Signed-off-by: elaihau <[email protected]>

Signed-off-by: elaihau <[email protected]>

Removing a check that seems to be a leftover from previous change [2] [1] eclipse-theia#8930 [2] eclipse-theia#5024 (comment) Signed-off-by: Alvaro Sanchez-Leon <[email protected]>

The issue was triggered by launching a debug session which includes a "preLaunchTask" referencing a build task. The issue happened even if the "cwd" option was present in the tasks.json file The check triggering the error was removed as the 'cwd' options should not be mandatory see 'options' under [3] as well as comment [2]. [1] eclipse-theia#8930 [2] eclipse-theia#5024 (comment) [3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks Signed-off-by: Alvaro Sanchez-Leon <[email protected]>

The issue was triggered by launching a debug session which includes a "preLaunchTask" referencing a build task. The issue happened even if the "cwd" option was present in the tasks.json file The check triggering the error was removed as the 'cwd' options should not be mandatory see 'options' under [3] as well as comment [2]. [1] #8930 [2] #5024 (comment) [3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks Signed-off-by: Alvaro Sanchez-Leon <[email protected]>

elaihau requested review from akosyakov and RomanNikitenko April 26, 2019 18:48

elaihau requested review from benoitf and evidolob as code owners April 26, 2019 18:48

elaihau requested a review from lmcbout April 26, 2019 18:48