Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create problem markers from task output #5024

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

elaihau
Copy link
Contributor

@elaihau elaihau commented Apr 26, 2019

What's included in this PR:

  • support taskDefinition, problemMatcher, & problemPattern contributed by Theia plugins.
  • support customizing tasks by adding named & anonymous problem matchers and patterns in .theia/tasks.json.
  • support parsing output from both "start - finish" tasks and "watch" tasks.
  • support both single line and multi line patterns.
  • create problem markers on parsing task output with the plugin-defined or user-defined problem matchers and patterns.

What's not included:

  • prompt users to provide problem matcher and / or patterns before starting tasks
  • remove problem markers automatically when problems are fixed

CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19787. Approved on June 4 2019.
CQ: https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20139. Approved on June 11 2019.

Resolves #4211

Signed-off-by: elaihau [email protected]

@elaihau elaihau requested a review from lmcbout April 26, 2019 18:48
@elaihau
Copy link
Contributor Author

elaihau commented Apr 26, 2019

Quick demo:

  1. Support customising tasks by providing named problem matcher(s):

Peek 2019-04-26 14-53

  1. Support customise tasks by providing anonymous problem matcher(s) and pattern(s):

Peek 2019-04-26 14-55

  1. Support watching tasks and background (aka. watching) pattern(s):

Peek 2019-04-26 15-04

@akosyakov
Copy link
Member

@elaihau Does it cover completely problem matching compare to VS Code? How do you verify it? I cannot see any references to some sample VS Code extensions, docs and don't see new tests in the PR.

@elaihau
Copy link
Contributor Author

elaihau commented May 7, 2019

Does it cover completely problem matching compare to VS Code?

No. "What's not included" is outlined in the description of the PR.

How do you verify it?

I tested it with running tasks detected by Gulp, Grunt, Jake, and NPM vscode extensions. And to be transparent, Jacques and I found some new missing stuffs when we sat together to test. I am currently working on problems we found.

I cannot see any references to some sample VS Code extensions, docs

Could you please be more specific ? I am not sure what you meant by "sample VS Code extensions, docs".

and don't see new tests in the PR.

will add tests. I am on it. Thank you !

@elaihau elaihau force-pushed the task_marker branch 5 times, most recently from b53bc0e to 19d3862 Compare May 15, 2019 12:23
@elaihau
Copy link
Contributor Author

elaihau commented May 28, 2019

This one has been opened for a while. @akosyakov could you please take a look when you get the chance? thank you !

@akosyakov
Copy link
Member

@elaihau will review it next month that it is landed in 0.8.0

@akosyakov
Copy link
Member

@elaihau but you can assign your colleagues and anybody else to help with a review, they should install some vscode extensions and check that everything you fixed is aligned with VS Code

@elaihau
Copy link
Contributor Author

elaihau commented Jul 3, 2019

@benoitf @evidolob I made some changes to the plugin-ext in this PR, are you ok with the change ? Thank you !

Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elaihau I'm fine with the changes in plugin-ext

@RomanNikitenko could you review again ?

@elaihau elaihau force-pushed the task_marker branch 2 times, most recently from 1acfd00 to f990231 Compare July 3, 2019 18:56
@RomanNikitenko
Copy link
Contributor

@RomanNikitenko could you review again ?

I am testing right now, thanks!

@RomanNikitenko
Copy link
Contributor

@RomanNikitenko could you review again ?

@benoitf
I tested the changes on minikube, started workspace from devfile.
Che tasks defined in devfile (I added simple commands like build and watch for theia project) work as expected except known issues.
The only thing I noticed that tasks from remote plugins are absent in 'Run tasks' menu (in my case I had typescript plugin).
But maybe something wrong with my assembly and typescript plugin has not started.
plugin_manager_error

@elaihau
Copy link
Contributor Author

elaihau commented Jul 4, 2019

The only thing I noticed that tasks from remote plugins are absent in 'Run tasks' menu (in my case I had typescript plugin).

@RomanNikitenko
Thank you for the testing
when you said "typescript plugin", did you refer to the typescript-language-features from vscode ? That one does not work with Theia. I haven't got the chance to go through its code to figure out what's missing in Theia.

@akosyakov akosyakov added tasks issues related to the task system vscode issues related to VSCode compatibility labels Jul 5, 2019
@elaihau
Copy link
Contributor Author

elaihau commented Jul 5, 2019

@RomanNikitenko could you please give me more details on the Theia plugin where you see the failure? It would be really nice if you could send me the url, if its source code is available somewhere online, or tell me its name if it comes from VS Code as an extension. Thank you !

Once I have more details from you, I will start some investigation to see where the problem occured.

@akosyakov
Copy link
Member

@RomanNikitenko please provide tests with example apps if you can, any contributor should be able to reproduce them without additional setups. If you cannot please let @elaihau know that he can continue working on compatibility with VS Code

@RomanNikitenko
Copy link
Contributor

RomanNikitenko commented Jul 8, 2019

@elaihau
I'm sorry for delay, we had three-day weekend in our office and I was offline.
I think you can merge your PR to do not delay the process, because maybe some problem is on our side.
I'll test again and create an issue if any problem will be found.
Is it OK for you?

@elaihau
Copy link
Contributor Author

elaihau commented Jul 9, 2019

@RomanNikitenko no worries ! I will rebase and merge this one. Please file an issue and cc me if you find any problems. Thanks !

elaihau added 2 commits July 8, 2019 20:04
What's included in this PR:
- support taskDefinition, problemMatcher, & problemPattern contributed by Theia plugins.
- support customizing tasks by adding named & anonymous problem matchers and patterns in .theia/tasks.json.
- support parsing output from both "start - finish" tasks and "watch" tasks.
- support both single line and multi line patterns.
- create problem markers on parsing task output with the plugin-defined or user-defined problem matchers and patterns.

What's not included:
- prompt users to provide problem matcher and / or patterns before starting tasks
- remove problem markers automatically when problems are fixed

CQ:
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=19787. Approved on June 4 2019.
https://dev.eclipse.org/ipzilla/show_bug.cgi?id=20139. Approved on June 11 2019.

Signed-off-by: elaihau <[email protected]>
@elaihau elaihau merged commit 4266b25 into eclipse-theia:master Jul 9, 2019
@elaihau elaihau deleted the task_marker branch July 9, 2019 00:24
alvsan09 added a commit to alvsan09/theia that referenced this pull request Jan 14, 2021
Removing a check that seems to be a leftover from previous change [2]

[1] eclipse-theia#8930
[2] eclipse-theia#5024 (comment)

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
alvsan09 added a commit to alvsan09/theia that referenced this pull request Jan 14, 2021
The issue was triggered by launching a debug session which includes a
"preLaunchTask" referencing a build task.

The issue happened even if the "cwd" option was present in the tasks.json file

The check triggering the error was removed as the 'cwd' options should not be
mandatory see 'options' under [3] as well as comment [2].

[1] eclipse-theia#8930
[2] eclipse-theia#5024 (comment)
[3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
paul-marechal pushed a commit that referenced this pull request Jan 18, 2021
The issue was triggered by launching a debug session which includes a
"preLaunchTask" referencing a build task.

The issue happened even if the "cwd" option was present in the tasks.json file

The check triggering the error was removed as the 'cwd' options should not be
mandatory see 'options' under [3] as well as comment [2].

[1] #8930
[2] #5024 (comment)
[3] https://code.visualstudio.com/docs/editor/tasks#_custom-tasks

Signed-off-by: Alvaro Sanchez-Leon <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tasks issues related to the task system vscode issues related to VSCode compatibility
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support vscode task contribution points
5 participants