Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[plugin] file management vscode commands #4980

Merged
merged 1 commit into from
May 9, 2019
Merged

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov commented Apr 24, 2019

partially address #4244

You can run vscode-api-tests and observe that tests closing editors after execution.

@akosyakov akosyakov force-pushed the ak/vscode_file_commands branch from f363888 to 318a68a Compare May 8, 2019 08:14
@akosyakov
Copy link
Member Author

@benoitf i've moved commands to vscode extension and included launch config for plugin api tests that we don't need to copy it each time.

@akosyakov akosyakov requested a review from tolusha May 8, 2019 08:29
Copy link
Contributor

@benoitf benoitf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 (I'm on EDT timezone this week)

@akosyakov akosyakov merged commit e147cf3 into master May 9, 2019
@akosyakov akosyakov deleted the ak/vscode_file_commands branch May 9, 2019 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants