Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use all the type hierarchy levels the server sends (fixes #4540) #4574

Merged
merged 1 commit into from
Mar 20, 2019
Merged

Use all the type hierarchy levels the server sends (fixes #4540) #4574

merged 1 commit into from
Mar 20, 2019

Conversation

HighCommander4
Copy link
Contributor

@HighCommander4 HighCommander4 commented Mar 15, 2019 •
edited by kittaakos
Loading

Closes #4540.

@HighCommander4 HighCommander4 mentioned this pull request Mar 15, 2019
Closed
@kittaakos
Copy link
Contributor

@HighCommander4, you have to sign your commit and also the ECA.

@HighCommander4
Copy link
Contributor Author

Updated to include signoff. Note, I do already have an ECA on file (I'm an Eclipse CDT committer).

@kittaakos
Copy link
Contributor

Updated to include signoff.

👍

have an ECA on file

✅ Confirmed.

kittaakos
kittaakos approved these changes Mar 20, 2019
View reviewed changes
Copy link
Contributor

@kittaakos kittaakos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 It works nicely; thank you for the patch, @HighCommander4!

Please note, once we get some feedback/approval on the textDocument/typeHierarchy proposal, we might change this behavior in Theia.

@kittaakos kittaakos merged commit 591dbb5 into eclipse-theia:master Mar 20, 2019
@HighCommander4
Copy link
Contributor Author

Thanks for merging!

Please note, once we get some feedback/approval on the textDocument/typeHierarchy proposal, we might change this behavior in Theia.

Understood. The C++ server implementation will be updated in line with any changes / clarifications in the spec as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kittaakos kittaakos kittaakos approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HighCommander4 @kittaakos