[Theia] Upgrade version of less to 3.0.3 for fixing the vulnerability in cryptiles package #4441
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akosyakov
reviewed
Feb 28, 2019
| @@ -41,7 +41,7 @@ | |||
| "font-awesome-webpack": "0.0.5-beta.2", | |||
| "fs-extra": "^4.0.2", | |||
| "ignore-loader": "^0.1.2", | |||
| "less": "^2.7.2", | |||
| "less": "^3.0.3", | |||
There was a problem hiding this comment.
Not now. We decided to not hold back such changes until the foundation has decided how to go forward.
|
@vinayb21 please commit changes to yarn.lock file |
@kittaakos The build failed. |
|
Having the macOS and the Windows green builds, I think it is safe to merge this PR. But I leave this decision for the reviewer :) |
… in cryptiles package Signed-off-by: vinayb21 <[email protected]>
svenefftinge
approved these changes
Feb 28, 2019
| @@ -41,7 +41,7 @@ | |||
| "font-awesome-webpack": "0.0.5-beta.2", | |||
| "fs-extra": "^4.0.2", | |||
| "ignore-loader": "^0.1.2", | |||
| "less": "^2.7.2", | |||
| "less": "^3.0.3", | |||
There was a problem hiding this comment.
Not now. We decided to not hold back such changes until the foundation has decided how to go forward.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4440