-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] include main-panel branding when empty #3910
Conversation
Thanks @akosyakov, I hadn't thought of implementing it with css variables earlier. |
logos should be part of distributed files of core package, i.e. belong to styles folder otherwise it won't work outside of Theia repo |
- Added some branding to the main-panel when there are no editors or widgets present in the panel. Signed-off-by: Vincent Fugnitto <[email protected]>
thanks for clarifying, I updated the PR based on your comment. I placed it under the |
We should move this to a 'branding' extension where we show how to provide product branding information by doing so by example for Theia. |
Stuff like #3600 should be done like that as well. |
And this one #3886 |
@svenefftinge @akosyakov |
@svenefftinge what do you mean by hooks? would properties in package.json work? We already have a section to provide configurations: https://github.com/theia-ide/theia/blob/b00646483ce663746ac8515cb945e680a9df2af2/examples/browser/package.json#L5-L11 |
present in the panel.
I thought Theia could use some branding options when there is no content in the main-panel, I am open however to programatically add the background image so that other products can more easily define their own branding. This is more of a proof of concept and I am open to changes/suggestions/ideas.
In the future we can also include common commands, helpful tips and links, the possibilities would be endless. For reference, here is vscode:
Signed-off-by: Vincent Fugnitto [email protected]