Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] include main-panel branding when empty #3910

Closed
wants to merge 1 commit into from
Closed

[core] include main-panel branding when empty #3910

wants to merge 1 commit into from

Conversation

vince-fugnitto
Copy link
Member

@vince-fugnitto vince-fugnitto commented Dec 28, 2018

  • Added some branding to the main-panel when there are no editors or widgets
    present in the panel.

I thought Theia could use some branding options when there is no content in the main-panel, I am open however to programatically add the background image so that other products can more easily define their own branding. This is more of a proof of concept and I am open to changes/suggestions/ideas.

Dark Bright
screen shot 2018-12-28 at 3 00 23 pm screen shot 2018-12-28 at 3 00 09 pm

In the future we can also include common commands, helpful tips and links, the possibilities would be endless. For reference, here is vscode:

screen shot 2018-12-28 at 1 32 27 pm

Signed-off-by: Vincent Fugnitto [email protected]

@vince-fugnitto vince-fugnitto added enhancement issues that are enhancements to current functionality - nice to haves core issues related to the core of the application ui/ux issues related to user interface / user experience labels Dec 28, 2018
@vince-fugnitto
Copy link
Member Author

Thanks @akosyakov, I hadn't thought of implementing it with css variables earlier.
I updated the PR, and also made the size a variable in case a product would like to change that as well!

@akosyakov
Copy link
Member

logos should be part of distributed files of core package, i.e. belong to styles folder

otherwise it won't work outside of Theia repo

- Added some branding to the main-panel when there are no editors or widgets
present in the panel.

Signed-off-by: Vincent Fugnitto <[email protected]>
@vince-fugnitto
Copy link
Member Author

vince-fugnitto commented Jan 2, 2019

logos should be part of distributed files of core package, i.e. belong to styles folder

otherwise it won't work outside of Theia repo

thanks for clarifying, I updated the PR based on your comment. I placed it under the icons folder, if it should be under a different or new folder just let me know.

@svenefftinge
Copy link
Contributor

svenefftinge commented Jan 2, 2019

We should move this to a 'branding' extension where we show how to provide product branding information by doing so by example for Theia.
The 'getting-started' extension could possibly be renamed to 'theia-branding' and contain more information (like logos, etc.).
Core could provide a contribution where a branding extension can hook in and provide the needed information.

@svenefftinge
Copy link
Contributor

Stuff like #3600 should be done like that as well.

@svenefftinge
Copy link
Contributor

And this one #3886

@vince-fugnitto
Copy link
Member Author

@svenefftinge @akosyakov
should I keep this PR on hold in favour of adding a branding extension this month that contributes the branding, logos, etc. and make the adjustments to core to accept a contribution hook?

@akosyakov
Copy link
Member

@svenefftinge what do you mean by hooks? would properties in package.json work? We already have a section to provide configurations: https://github.com/theia-ide/theia/blob/b00646483ce663746ac8515cb945e680a9df2af2/examples/browser/package.json#L5-L11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core issues related to the core of the application enhancement issues that are enhancements to current functionality - nice to haves ui/ux issues related to user interface / user experience
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants