[monaco] Fix keybindings on os x #3835
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kittaakos could you check on windows as well? |
kittaakos
reviewed
Dec 14, 2018
| @@ -79,7 +79,7 @@ export class MonacoKeybindingContribution implements KeybindingContribution { | |||
| first: Key.getKey(monaco2BrowserKeyCode(keyCode & 255)), | |||
| modifiers: [] | |||
| }; | |||
| if (keybinding.ctrlKey) { | |||
| if (keybinding.metaKey) { | |||
There was a problem hiding this comment.
I think with this change, we never add Ctrl to the sequence in Windows... I am verifying it anyways
There was a problem hiding this comment.
We rely on the mapping logic from monaco:
https://github.com/Microsoft/vscode/blob/master/src/vs/base/common/keyCodes.ts#L428
There was a problem hiding this comment.
The logic should be something like this
IF OS === macOS AND isMeta AND isCtrlthen it is aCtrlCmdIF OS === macOS AND !isMeta AND isCtrlthe it is aMacCtrl(this should not do anything on Windows)IF OS !== macOS AND isCtrlthen it is aCtrlCmd
There was a problem hiding this comment.
I see. So it is already handled by monaco. Thanks for the clarification.
|
Space does not work anymore in Windows. It always shows the CA instead:
|
|
oh, how convenient :-) |
Fixes #3834 Signed-off-by: Sven Efftinge <[email protected]>
svenefftinge
force-pushed
the
GH-3834
branch
from
10810a0 to
5ed0803
Compare
kittaakos
approved these changes
Dec 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3834
Signed-off-by: Sven Efftinge [email protected]