Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-3791 don't swallow output from shell tasks #3794

Closed
wants to merge 1 commit into from
Closed

Conversation

JanKoehnlein
Copy link
Contributor

Signed-off-by: Jan Koehnlein [email protected]

@simark
Copy link
Contributor

simark commented Dec 10, 2018

I am working on tasks and process stuff, so I'd like to have a bit of time to look at this, if possible. We had also noticed issues about short-lived tasks (see #2961).

@simark
Copy link
Contributor

simark commented Dec 10, 2018

Apart from the discussions we have on #3791, I tried this locally. I noticed that the shell stays open after the "task" (the process we want to run) has ended, which means the task never properly ends.

@simark
Copy link
Contributor

simark commented Dec 10, 2018

If we want to run things through a shell (and we'll want to, that's the point of shell tasks), I think we'll want to run them using bash -c '... or equivalent. I dug in node's child_process.spawn code a while ago, I think that's how it does.

@paul-marechal
Copy link
Member

Also seems to be breaking some tests.

@vince-fugnitto vince-fugnitto added process issues related to the process extension tasks issues related to the task system labels Jan 31, 2020
@vince-fugnitto
Copy link
Member

I believe the pull-request can be closed, at the moment it is quite outdated (2018) and is inactive.
I propose we open a new pull-request if we ever want to revisit such a feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
process issues related to the process extension tasks issues related to the task system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants