Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[onhold] GH-2009: Bumped up a few versions to support Node.js 10.x. #3358

Closed
wants to merge 3 commits into from
Closed

[onhold] GH-2009: Bumped up a few versions to support Node.js 10.x. #3358

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1e12147
GH-2009: Bumped up a few versions to support Node.js `10.x`.
Oct 31, 2018
4fa096f
[DROP-ME] GH-2009: Switched to Node.js 10 on the CIs.
Oct 31, 2018
b6df25a
[DROP-ME] Switched from Node.js 10 to Current.
kittaakos Nov 1, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
sudo: required
language: node_js
node_js: '8'
kittaakos marked this conversation as resolved.
Show resolved Hide resolved
node_js: '10'
git:
depth: 1
cache:
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ shallow_clone: true

environment:
matrix:
- nodejs_version: "8"
- nodejs_version: "Current"

platform:
- x64
Expand Down
3 changes: 1 addition & 2 deletions doc/Developing.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,8 +46,7 @@ For Windows instructions [click here](#building-on-windows).
## Prerequisites
- Node.js `>= 8.x`, `< 9.x`.
- Preferably, **use** version `8.11.4`, it has the [active LTS](https://github.com/nodejs/Release).
- Node.js `9.x` is untested.
- Node.js `10.x` is **not** supported yet due to a known issue in [`nsfw`](https://github.com/theia-ide/theia/issues/2009).
- Both Node.js `9.x` and `10.x` are untested.
- [Yarn package manager](https://yarnpkg.com/en/docs/install) v1.7.0
- git (If you would like to use the Git-extension too, you will need to have git version 2.11.0 or higher.)

Expand Down
8 changes: 4 additions & 4 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,10 +41,10 @@
"typedoc": "^0.8",
"typescript": "^3.1.3",
"uuid": "^3.1.0",
"wdio-mocha-framework": "0.5.9",
"wdio-selenium-standalone-service": "0.0.8",
"wdio-spec-reporter": "0.1.0",
"webdriverio": "4.9.2"
"wdio-mocha-framework": "^0.6.4",
"wdio-selenium-standalone-service": "^0.0.10",
"wdio-spec-reporter": "^0.1.5",
"webdriverio": "^4.14.0"
},
"scripts": {
"prepare": "yarn prepare:travis && yarn prepare:hoisting && yarn rebuild:clean && yarn build:clean",
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@
"reflect-metadata": "^0.1.10",
"route-parser": "^0.0.5",
"vscode-languageserver-types": "^3.10.0",
"vscode-nsfw": "^1.0.17",
"vscode-nsfw": "^1.1.1",
"vscode-uri": "^1.0.1",
"vscode-ws-jsonrpc": "^0.0.2-1",
"ws": "^5.2.2",
Expand Down
Loading