Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade TS language server #2516

Merged
merged 1 commit into from
Aug 9, 2018
Merged

upgrade TS language server #2516

merged 1 commit into from
Aug 9, 2018

Conversation

akosyakov
Copy link
Member

@akosyakov akosyakov requested a review from svenefftinge August 6, 2018 13:44
svenefftinge
svenefftinge previously approved these changes Aug 6, 2018
View reviewed changes
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@akosyakov akosyakov force-pushed the ak/upgrade_ts branch 2 times, most recently from 38d1163 to f753ecb Compare August 7, 2018 07:51
@akosyakov
Copy link
Member Author

@svenefftinge I've integrated typescript-language-server/typescript-language-server#51 to improve completion and signature help response. Please try again.

@akosyakov akosyakov force-pushed the ak/upgrade_ts branch 3 times, most recently from 79b1339 to c301383 Compare August 8, 2018 07:13
@svenefftinge
Copy link
Contributor

I will review typescript-language-server/typescript-language-server#51 once you removed the WIP prefix.

@akosyakov
upgrade TS language server
f717503 
Signed-off-by: Anton Kosyakov <[email protected]>
@akosyakov akosyakov changed the title WIP upgrade TS language server upgrade TS language server Aug 9, 2018
@akosyakov
Copy link
Member Author

@svenefftinge please review, for outstanding Rename File command support I will do a separate RP, it is a bit involving, since we are not capable to detect renames yet

svenefftinge
svenefftinge approved these changes Aug 9, 2018
View reviewed changes
Copy link
Contributor

@svenefftinge svenefftinge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! :)

@akosyakov akosyakov merged commit 5336443 into master Aug 9, 2018
@akosyakov akosyakov deleted the ak/upgrade_ts branch August 9, 2018 15:13
@akosyakov akosyakov mentioned this pull request Aug 10, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenefftinge svenefftinge svenefftinge approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akosyakov @svenefftinge