Fix the onDidChangeActiveNotebookEditorEmitter to fire correctly #14321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tor changed Signed-off-by: Jonah Iden <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes the onDidChangeActiveNotebookEditorEmitter to fire correctly when the active notebook has been changed.
This should also fix the issue with the jupyter variables button not appearing
How to test
You can again test with my notebook selection test extension
this should show that the active notebook editor should always be correct.
Also the jupyter variables button should now appear again
Follow-ups
@dhuebner maybe good candidate for automated ui tests?
Review checklist
Reminder for reviewers