fix: do not override user-defined THEIA_CONFIG_DIR #13708
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The current behavior of Theia is to ignore a user-defined
THEIA_CONFIG_DIR
environment variable, which is an unexpected regression from a user's point of view.This patch ensures that a user-defined value has precedence over the
BackendApplicationPath/data/user-data
location and the default location~/.theia
.Fixes #13700
Contributed on behalf of STMicroelectronics
How to test
THEIA_CONFIG_DIR
environment variable to a non-default value:export THEIA_CONFIG_DIR=~/theia-test-data-dir
yarn browser start
)Follow-ups
Review checklist
Reminder for reviewers