Fix incorrect URI conversions in custom-editors-main.ts
#13653
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Currently,
custom-editors-main.ts
contains multiple instances of Theia to VSCode URI conversions of the formURI.file(uri.path.toString())
, which seem to be incorrect in the general case. This PR replaces them withURI.from(uri.toComponents())
or justuri.toComponents()
as appropriate.How to test
I don't have a specific test case for this, but hopefully it can be verified by code inspection.
Review checklist
Reminder for reviewers