-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixes clear cell outputs command and improves toolbar creation #13640
Conversation
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This works partially: When initially rendering the output, changing the presentation doesn't work on the first attempt. Only after clearing the output and then rerunning the cell does it work as expected. Also, changing from image to text and then back to image simply removes (?) the output. Only after running the cell again, I get to see the image output. See the attached video:
2024-04-25.15-08-05.mp4
Signed-off-by: Jonah Iden <[email protected]>
Signed-off-by: Jonah Iden <[email protected]>
@msujew the sometimes not being able to change the presentation should be fixed, as described in the follow ups the problem with going back to image seems to be a larger one. I would work on that on a separate PR |
Signed-off-by: Jonah Iden <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, in this case, this looks good to me 👍
What it does
This fixes the
clear cell output
andchange presentation
from the cell sidebar context menuHow to test
Open or create a notebook including a cell with multiple output representations.
For example the following (requires PIL installed in the kernel)
Check that changing the ouptut presentation works.
Check that clearing the output works.
Follow-ups
There is currently no support for multiple outputs yet. So if you have two outputs both are affected by the actions.
Also it seems there is still a bug with going back to images after changing to text
Review checklist
Reminder for reviewers