Fix onLanguage activation event #13630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the the VSCode documentation `onLanguage` (without any language specified) is a valid activation event. This is used in the built-in emmet extension for example. Beforehand extensions with this event were not triggered. With this commit the extensions with `onLanguage` are activated, when the first language is loaded.
|
@sgraband how do I verify that "emmet is working"? I get a bunch of proposals, but are they from emmet? How do I tell? |
|
They will have
|
tsmaeder
approved these changes
Apr 22, 2024
|
Does this also fix #13607? |
|
I see no reason, on why this should not fix that issue as soon as we update the try.theia-cloud.io deployment. However, we normally only do this for community relases as far as i know. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
According to the the VSCode documentation
onLanguage(without any language specified) is a valid activation event.This is used in the built-in emmet extension for example.
Beforehand extensions with this event were not triggered.
With this commit the extensions with
onLanguageare activated, when the first language is loaded.Fixes #13247
How to test
Check that the built-in emmet extension is working by opening an empty
.jsxfile, typingdiand triggering the suggestions (Ctrl+Space). You should get two suggestions from Emmet (diranddiv).Without this change you would get no suggestions, as the extension would not be activated.
Follow-ups
Review checklist
Reminder for reviewers