Duplicate Clipboard actions in editor context menu #13626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Prevents menu action registration for monaco menu items if a corresponding mapping command was already registered.
For example if
core.cutcommand, which is a mapper foreditor.action.clipboardCutAction(seeMonacoCommands.COMMON_ACTIONS) already registered in the editor's context menu, theeditor.action.clipboardCutActioncommand item will not be added to the menu.See #13619
How to test
Open a text editor, open the context menu. Check the clipboard actions group, there should be no duplicate entries for Cut/Copy/Paste.
Follow-ups
Review checklist
Reminder for reviewers