Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix non recursive folder delete using file system #13361

Merged
merged 1 commit into from
Feb 9, 2024
Merged

Fix non recursive folder delete using file system #13361

merged 1 commit into from
Feb 9, 2024

Commits on Feb 7, 2024

  1. Fix file system delete of folder 

    Deleting a folder without recursive enabled failed as the used
nodejs API unlink does not support folder deletion.
Fixing it by first checking if it is a folder, and if so
using rmdir instead.

Added a simple unit test, which also exposed that
the folder deletion also fails when using trash support,
but that is a different issue.

Signed-off-by: Daniel Friederich <[email protected]>
    @dfriederich
    dfriederich committed Feb 7, 2024
    Configuration menu
    Copy the full SHA
    7ec7b93 View commit details
    Browse the repository at this point in the history