Fix vscode.env.appRoot path
#13285
Merged
Fix vscode.env.appRoot path
#13285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
msujew
force-pushed
the
msujew/vscode-env-appRoot
branch
from
7034ea5
to
a02c823
Compare
|
@msujew, I tried to reproduce the steps you provided, but I always get 'undefined' as an app root, both browser and electron. Shouldn't envExt#setAppRoot be called on plugin manager $init (https://github.com/eclipse-theia/theia/blob/msujew/vscode-env-appRoot/packages/plugin-ext/src/plugin/plugin-manager.ts#L461) and the headless plugin manager? |
|
@rschnekenbu Thanks, it broke during the latest rebase on the headless plugin host commit. I've fixed it again. |
jfaltermeier
approved these changes
Jan 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Closes #11477
Extends the
ApplicationServerto also return theappRoot. We now use this new field to provide the plugin host with an accurate app root directory.How to test
appRoot#11477.../theia/examples/browseror.../theia/examples/electron)Review checklist
Reminder for reviewers