Memory Leak when using MessageService#showProgress on Backend #13253

[jfaltermeier]

What it does

• dispose cancellation event listeners in RpcProtocol

Fixes #13253

How to test

See reproducer in #13253

Follow-ups

/

Review checklist

• As an author, I have thoroughly tested my changes and carefully followed the review guidelines

Reminder for reviewers

• As a reviewer, I agree to behave in accordance with the review guidelines

[martin-fleck-at]

Change looks good to me and works great, thank you Johannes! I just have a minor issue with the naming but then we can merge this.

[martin-fleck-at]

I really like the idea of this class and I believe we can even add it to the common disposable.ts. From my understanding it is a wrapper that you mark as disposed and either the already given disposable or any later set disposable is then also disposed, making sure that whatever is given to the wrapper has the correct disposed state.

So I think that this class should actually also implement Disposable so it actually acts more like a wrapper fulfilling the same interface. Also, from the name alone it is not very clear what this class does, so maybe something like DelayedDisposable or actually WrappedDisposable or DisposableWrapper might be better. I believe we could even see this as a special case of the DisposableCollection with an adapted push that does not add things to the collection once dispose was called but instead simply disposes anything that is added to it, so maybe we could also adapt it to that. That would also solve the problem of people calling setDisposable multiple times without knowing whether we already wrapped a disposable or not.

However, I'll leave it up to you, I just think we should share it in a more common API and fix the naming a bit.

[jfaltermeier]

I'll move it to disposable.ts. I am not sure about DisposableCollection though. If something like this is needed with a collection I would rather expect people placing the wrapper inside a disposable collection, which is possible now with implementing Disposable.

[martin-fleck-at]

Sure, I'm fine with that.

[martin-fleck-at]

Changes look good to me now, thank you very much Johannes!