Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add autoClosingPairs field to LanguageConfiguration API #13088

Merged
merged 2 commits into from
Nov 28, 2023

Conversation

tsmaeder
Copy link
Contributor

What it does

Fixes #13060

Contributed on behalf of STMicroelectronics

How to test

The attached extension contributes a command "Set Closing Pairs". It sets the closing pairs for the typescript language to "asdf"/"fdsa", but only in strings. After invoking it, when you type asdf inside a string, the string fdsa will be inserted, but only if there is a space after the insert location.

Review checklist

Reminder for reviewers

@tsmaeder
Copy link
Contributor Author

@tortmayr a smallish one for the 1.83.1 vscode compat.

@tsmaeder
Copy link
Contributor Author

Here's the vsix:
closingpairs-0.0.1.zip

and here's the source:

closingpairs.zip

Copy link
Contributor

@tortmayr tortmayr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Code looks good to me and the tested extension works a expected 👍🏼

@tortmayr
Copy link
Contributor

@tsmaeder Conflicts need to be resolved before we can merge this

Contributed on behalf of STMicroelectronics

Signed-off-by: Thomas Mäder <[email protected]>
Signed-off-by: Thomas Mäder <[email protected]>
@tsmaeder tsmaeder merged commit de5a4b3 into eclipse-theia:master Nov 28, 2023
14 checks passed
@vince-fugnitto vince-fugnitto added this to the 1.44.0 milestone Nov 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[vscode] Support LanguageConfiguration autoClosingPairs
3 participants