Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #12546: UI not updated upon editing breakpoint condition #12980

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Fix #12546: UI not updated upon editing breakpoint condition #12980

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion packages/debug/src/browser/breakpoint/breakpoint-manager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ export class BreakpointManager extends MarkerManager<SourceBreakpoint> {
added.push(newMarker);
} else {
// We emit all existing markers as 'changed', but we only fire an event if something really did change.
didChangeMarkers ||= !!added.length || !deepEqual(oldMarker, newMarker);
// We also fire an event if oldMarker === newMarker, as we cannot actually detect a change in this case
// (https://github.com/eclipse-theia/theia/issues/12546).
didChangeMarkers ||= !!added.length || oldMarker === newMarker || !deepEqual(oldMarker, newMarker);
changed.push(newMarker);
}
}
Expand Down
Loading