tabbar: fix command contributions regression #12869
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merge of eclipse-theia#12799 introduced a regression in the rendering of MenuToolbarItems that aren't pop-up menus but instead just commands that happen to have a menu path: they were rendered as pop-up menus instead of simple buttons. This fix refines the condition for the new pop-up menu rendering to check that the menu to be rendered is not a command to be executed directly on click. Fixes eclipse-theia#12687 Signed-off-by: Christian W. Damus <[email protected]>
|
@martin-fleck-at this is a follow-up to fix a regression caused by a PR that you reviewed, yesterday. Would you mind having a look? TIA! |
1 task
martin-fleck-at
approved these changes
Aug 29, 2023
There was a problem hiding this comment.
Thank you for finding this! I can confirm that it works as expected again, thank you very much @cdamus!
vince-fugnitto
added
vscode
This was referenced Nov 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The merge of #12799 introduced a regression in the rendering of
MenuToolbarItems that aren't pop-up menus but instead just commands thathappen to have a menu path: they were rendered as pop-up menus instead of simple buttons.
This fix refines the condition for the new pop-up menu rendering to check that the menu to be rendered is not a command to be executed directly on click.
Fixes #12687
How to test
menu_bug_1branch.myextextension to the toolbar are rendered as separate buttons that don't show pop-up menus when clicked but just execute their commands, as is correct. Note that the action without the icon will not be rendered correctly, which is the problem to be addressed in Icon-less VS Code “editor/title” menu contribution not rendered properly #12686. It should look like this, exactly as in the description of 12686:Review checklist
Reminder for reviewers