Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getting-started: fix checkbox overlapping with other content for small viewports #12825

Merged
merged 1 commit into from
Aug 21, 2023

Conversation

vladarama
Copy link
Contributor

What it does

Fixes: #12822

This PR fixes the issue with the getting-started preference checkbox overlapping with other content for small viewports. It achieves this by adding styling to the main getting-started container which includes: justify-content: space-between.

Before:
checkbox styling error

After:
checkbox styling fix

How to test

  1. Open Theia.
  2. If welcome page is not opened, open the command palette (Ctrl+Shift+p) and search for welcome.
  3. Resize the application, reducing its view.
  4. The preference checkbox should not overlap with other content.

Review checklist

Reminder for reviewers

This commit adds a className and styling to the main div containing the
getting-started content and the preferences which fixes the overlapping
checkbox for small viewports.

Signed-off-by: Vlad Arama <[email protected]>
@vince-fugnitto vince-fugnitto added getting-started issues related to the getting-started extension ui/ux issues related to user interface / user experience labels Aug 15, 2023
Copy link
Member

@vince-fugnitto vince-fugnitto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I confirmed the resizing behavior is much better compared to master 👍

@vince-fugnitto vince-fugnitto merged commit 3a49fca into eclipse-theia:master Aug 21, 2023
6 checks passed
@vladarama vladarama deleted the checkbox-overflow branch August 21, 2023 19:46
@vince-fugnitto vince-fugnitto added this to the 1.41.0 milestone Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getting-started issues related to the getting-started extension ui/ux issues related to user interface / user experience
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

getting-started: improve checkbox display for small viewports
2 participants