Commits on Aug 28, 2023

1. tabbar: fix command contributions regression …

   The merge of eclipse-theia#12799 introduced a regression in
   the rendering of MenuToolbarItems that aren't
   pop-up menus but instead just commands that
   happen to have a menu path: they were rendered
   as pop-up menus instead of simple buttons.
   
   This fix refines the condition for the new pop-up
   menu rendering to check that the menu to be
   rendered is not a command to be executed
   directly on click.
   
   Fixes eclipse-theia#12687
   
   Signed-off-by: Christian W. Damus <[email protected]>

   

   cdamus committed Aug 28, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for b702ee0
   • Browse repository at this point

   Copy the full SHA

   b702ee0 View commit details

   Browse the repository at this point in the history

2. tabbar: support icon-less items …

   VS Code renders action buttons in the tab bar
   for commands that do not have icons using
   their title text, instead. This commit does the
   same in Theia.
   
   Additionally, two related minor issues are fixed:
   
   - the $(icon) specifiers for icons show in the
     tooltip of an action, which is confusing
   - the roll-over highlight shows only on action
     buttons for commands that use the "icon"
     property, not those that embed icon specifiers
     in their titles
   
   Fixes eclipse-theia#12686
   
   Signed-off-by: Christian W. Damus <[email protected]>

   

   cdamus committed Aug 28, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for a608abe
   • Browse repository at this point

   Copy the full SHA

   a608abe View commit details

   Browse the repository at this point in the history