core: refactor manage sidebar menu
#12803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vince-fugnitto
force-pushed
the
vf/manage-sidebar
branch
from
11ab548
to
4be2ce8
Compare
msujew
approved these changes
Sep 12, 2023
|
@vince-fugnitto Do you plan to merge this before the release? |
vince-fugnitto
force-pushed
the
vf/manage-sidebar
branch
2 times, most recently
from
d7dafe9
to
a3e7f1a
Compare
The commit refactors the `manage` sidebar menu (previously settings) to the same organization present in vscode with similar commands. Signed-off-by: vince-fugnitto <[email protected]>
vince-fugnitto
force-pushed
the
vf/manage-sidebar
branch
from
a3e7f1a
to
087e984
Compare
|
@vince-fugnitto Can this be merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The pull-request refactors the sidebar menu (bottom settings-cog icon) to more closely align with VS Code.
The menu was refactored to
manageand contains additional menu items in a more clear ordering.Before:
After:
How to test
Review checklist
Reminder for reviewers