plugin-ext: stop reading before writing stores #12717
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The merging of on disk values using `deepmerge` is bogus. Instead we'll completely overwrite the file. This should be fine as the `PluginsKeyValueStorage` singleton is shared across all plugin host processes, meaning there shouldn't be a risk for a race condition to corrupt the file being written on disk. Note that there is still a race condition risk when multiple Theia backends are running on the same host, but odds should be low.
tsmaeder
approved these changes
Jul 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The merging of on disk values using
deepmergeis bogus.Instead we'll completely overwrite the file. This should be fine as the
PluginsKeyValueStoragesingleton is shared across all plugin host processes, meaning there shouldn't be a risk for a race condition to corrupt the file being written on disk.Note that there is still a race condition risk when multiple Theia backends are running on the same host, but odds should be low.
How to test
Help needed
Review checklist
Reminder for reviewers